Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Update tests to resolve OSSM Kiali issue #1129

Merged
merged 2 commits into from
Feb 20, 2025
Merged

[Chore] Update tests to resolve OSSM Kiali issue #1129

merged 2 commits into from
Feb 20, 2025

Conversation

IshwarKanse
Copy link
Contributor

@IshwarKanse IshwarKanse commented Feb 20, 2025 •
edited
Loading

The PR resolves issue with Kiali not starting up due to bug kiali/kiali#8071

--- PASS: chainsaw (1012.27s)
    --- PASS: chainsaw/ossm-monolithic-otel (303.90s)
    --- PASS: chainsaw/ossm-tempostack (332.82s)
    --- PASS: chainsaw/ossm-tempostack-otel (375.56s)
PASS
Tests Summary...
- Passed  tests 3
- Failed  tests 0
- Skipped tests 0
Done.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.61%. Comparing base (29c396b) to head (c5e359b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   58.61%   58.61%           
=======================================
  Files         113      113           
  Lines       10208    10208           
=======================================
  Hits         5983     5983           
  Misses       3917     3917           
  Partials      308      308
Flag Coverage Δ
unittests 58.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasgerstmayr andreasgerstmayr enabled auto-merge (squash) February 20, 2025 15:41
@andreasgerstmayr andreasgerstmayr merged commit 7846041 into grafana:main Feb 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasgerstmayr andreasgerstmayr andreasgerstmayr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IshwarKanse @codecov-commenter @andreasgerstmayr